Fix the logging example so that it is valid JS#1172
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 71.83% 71.83%
=======================================
Files 15 15
Lines 1360 1360
Branches 405 405
=======================================
Hits 977 977
Misses 312 312
Partials 71 71 Continue to review full report at Codecov.
|
Contributor
|
@filmaj Thanks for fixing this! Can you apply the same changes to Japanese page too? |
Contributor
Author
|
Of course! Incoming shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tried copy+pasting the logging example and it didn't compile because it is not syntactically correct. Tweaking it to try to make it so!
Requirements (place an
xin each[ ])