Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the SlackApi version to the current #118

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

cchensh
Copy link
Contributor

@cchensh cchensh commented Nov 1, 2022

Summary

Bump the SlackApi version to the current

Requirements (place an x in each [ ])

@cchensh cchensh requested a review from vegeris November 1, 2022 18:25
@cchensh cchensh requested a review from a team as a code owner November 1, 2022 18:25
@cchensh cchensh self-assigned this Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #118 (b5e9058) into main (72b57ac) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   98.56%   98.63%   +0.07%     
==========================================
  Files          47       47              
  Lines        1875     1827      -48     
  Branches      105      105              
==========================================
- Hits         1848     1802      -46     
+ Misses         25       23       -2     
  Partials        2        2              
Impacted Files Coverage Δ
src/deps.ts 100.00% <100.00%> (ø)
src/workflows/mod.ts 95.50% <0.00%> (-0.42%) ⬇️
src/manifest/mod.ts 97.89% <0.00%> (-0.06%) ⬇️
src/functions/interactivity/view_router.ts 99.13% <0.00%> (-0.03%) ⬇️
src/functions/mod.ts 100.00% <0.00%> (ø)
src/functions/slack-function.ts 100.00% <0.00%> (ø)
...rc/functions/interactivity/block_actions_router.ts 100.00% <0.00%> (ø)
...functions/interactivity/block_suggestion_router.ts 100.00% <0.00%> (ø)
src/workflows/workflow-step.ts 89.58% <0.00%> (+0.47%) ⬆️
src/parameters/mod.ts 94.20% <0.00%> (+0.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@vegeris vegeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to make (update the import in the sdk) but I'm unable to reproduce the compilation error mentioned in the bug

Attempt to reproduce: my app's import_map.json is set to api@1.3.0 and app includes an an import statement for the current latest sdk (1.4.0) (import { SlackAPIClient } from "deno-slack-sdk/deps.ts";)

@cchensh cchensh merged commit 8d32b18 into main Nov 1, 2022
@cchensh cchensh deleted the cheng-update-slackapi-version branch November 1, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants