Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the workflow callback_id generic #88

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Make the workflow callback_id generic #88

merged 2 commits into from
Aug 26, 2022

Conversation

shapirone
Copy link
Collaborator

@shapirone shapirone commented Aug 25, 2022

Summary

This makes it so that we respect the value passed into callback_id, rather than treating it as any old string. This is necessary for us to key off of callback_id to know what should be passed into a trigger's workflow parameter in the API.

Testing

There is no functional difference here, but you could test making and deploying workflows for a sanity check.

Requirements (place an x in each [ ])

@shapirone shapirone requested a review from a team as a code owner August 25, 2022 01:34
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #88 (cc3f6a7) into main (8f53935) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          41       41           
  Lines        1565     1565           
  Branches       87       87           
=======================================
  Hits         1504     1504           
  Misses         59       59           
  Partials        2        2           
Impacted Files Coverage Δ
src/workflows/mod.ts 87.75% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jmplexi jmplexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirone shapirone merged commit 2f76241 into main Aug 26, 2022
@shapirone shapirone deleted the neil-wf-cb-generic branch August 26, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants