Make the workflow callback_id generic #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes it so that we respect the value passed into
callback_id
, rather than treating it as any oldstring
. This is necessary for us to key off ofcallback_id
to know what should be passed into a trigger'sworkflow
parameter in the API.Testing
There is no functional difference here, but you could test making and deploying workflows for a sanity check.
Requirements (place an
x
in each[ ]
)