-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some deprecated items #91
Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 96.34% 98.31% +1.97%
==========================================
Files 44 44
Lines 1669 1664 -5
Branches 90 90
==========================================
+ Hits 1608 1636 +28
+ Misses 59 26 -33
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove handling from the Custom Type export
method as well. Should we do a doc sweep looking for callback_id
or FunctionHandler
?
Did a pass at the docs and didn't find any mention of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This removes 2 deprecated items:
FunctionHandler
export that was replaced withSlackFunctionHandler
type.callback_id
that was replaced withname
.Requirements (place an
x
in each[ ]
)