Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated items #91

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

selfcontained
Copy link
Contributor

Summary

This removes 2 deprecated items:

  • Top level FunctionHandler export that was replaced with SlackFunctionHandler type.
  • CustomType definitions support for callback_id that was replaced with name.

Requirements (place an x in each [ ])

@selfcontained selfcontained requested a review from a team as a code owner August 29, 2022 21:08
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #91 (bb947af) into main (6650c12) will increase coverage by 1.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   96.34%   98.31%   +1.97%     
==========================================
  Files          44       44              
  Lines        1669     1664       -5     
  Branches       90       90              
==========================================
+ Hits         1608     1636      +28     
+ Misses         59       26      -33     
  Partials        2        2              
Impacted Files Coverage Δ
src/types/mod.ts 100.00% <100.00%> (ø)
src/workflows/mod.ts 94.89% <0.00%> (+7.14%) ⬆️
src/manifest/mod.ts 97.83% <0.00%> (+7.79%) ⬆️
src/workflows/workflow-step.ts 89.10% <0.00%> (+7.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@shapirone shapirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove handling from the Custom Type export method as well. Should we do a doc sweep looking for callback_id or FunctionHandler?

src/types/mod.ts Show resolved Hide resolved
@selfcontained
Copy link
Contributor Author

Let's remove handling from the Custom Type export method as well. Should we do a doc sweep looking for callback_id or FunctionHandler?

Did a pass at the docs and didn't find any mention of them.

Copy link
Collaborator

@shapirone shapirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@selfcontained selfcontained merged commit f6b5a15 into main Aug 29, 2022
@selfcontained selfcontained deleted the bradh-remove-some-deprecated-items branch August 29, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants