Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unassociated bot user #507

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

shaydewael
Copy link
Contributor

Summary

If a bot user has no association to a user id, make sure it's still defined.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #507 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #507      +/-   ##
=========================================
+ Coverage   85.26%   85.3%   +0.04%     
=========================================
  Files           6       6              
  Lines         346     347       +1     
  Branches       75      75              
=========================================
+ Hits          295     296       +1     
  Misses         29      29              
  Partials       22      22
Impacted Files Coverage Δ
src/client.coffee 95% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f019e...39d0d46. Read the comment docs.

@shaydewael shaydewael merged commit e1ca6b2 into slackapi:master Jul 10, 2018
@shaydewael shaydewael deleted the fix-unassociated-bot-user branch July 10, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants