Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add compatibility for Coffeescript 2 #528

Closed
wants to merge 2 commits into from

Conversation

mistydemeo
Copy link
Contributor

Summary

This PR starts the work on making sure the classes in this code work in Coffeescript 2. As mentioned previously, a few of the semantic differences between Coffeescript 1 classes and ES2015 classes has introduced some backwards compatibility issues, documented here: https://coffeescript.org/#breaking-changes

Currently, this mostly works, but trying to actually launch Hubot fails with a TypeError: Cannot read property 'bind' of undefined error. I believe this may be because of the following:

ES2015 classes don’t allow bound (fat arrow) methods. The CoffeeScript compiler goes through some contortions to preserve support for them, but one thing that can’t be accommodated is calling a bound method before it is bound

refs #526.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2018

CLA assistant check
All committers have signed the CLA.

@seratch
Copy link
Member

seratch commented Apr 24, 2020

Let me close this as #565 has been merged into master branch

@seratch seratch closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants