Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect bot_id usage #617

Merged
merged 3 commits into from
Jan 27, 2021
Merged

fix incorrect bot_id usage #617

merged 3 commits into from
Jan 27, 2021

Conversation

buzztaiki
Copy link
Contributor

Summary

This PR fixes #615.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Jan 14, 2021
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2021

CLA assistant check
All committers have signed the CLA.

@misscoded misscoded added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed untriaged labels Jan 14, 2021
@seratch
Copy link
Member

seratch commented Jan 14, 2021

Thanks a lot @buzztaiki ! We will merge this PR after I fix the CI builds of this project (I do not have anything further to work on).

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #617 (c32809d) into main (767900a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files           6        6           
  Lines         408      408           
  Branches       91       91           
=======================================
  Hits          342      342           
  Misses         38       38           
  Partials       28       28           
Impacted Files Coverage Δ
src/client.coffee 89.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767900a...c32809d. Read the comment docs.

@seratch seratch added this to the 4.9.0 milestone Jan 27, 2021
@seratch seratch merged commit 0fe83a2 into slackapi:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When receiving a bot writing message using the User OAuth Token, the res.message.user has room property only
4 participants