Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1308 repsonse_metadata is missing in admin.initeRequests.list/*.list response classes #1310

Merged
merged 1 commit into from
May 10, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented May 10, 2024

This pull request reolves #1308

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model labels May 10, 2024
@seratch seratch added this to the 1.39.1 milestone May 10, 2024
@seratch seratch self-assigned this May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (6a1733c) to head (58ea869).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1310   +/-   ##
=========================================
  Coverage     74.83%   74.83%           
  Complexity     4127     4127           
=========================================
  Files           443      443           
  Lines         12786    12786           
  Branches       1319     1319           
=========================================
  Hits           9569     9569           
  Misses         2453     2453           
  Partials        764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit fe832e5 into slackapi:main May 10, 2024
6 checks passed
@seratch seratch deleted the issue-1308-admin-invite-requests branch May 10, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant