Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for OpenJDK 11's bug #452

Merged
merged 1 commit into from May 12, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 12, 2020

Summary

Sending HTTP requests to Slack API server on OpenJDK 11 fails due to https://bugs.openjdk.java.net/browse/JDK-8211806

Requirements (place an x in each [ ])

@seratch seratch added the project:slack-api-client project:slack-api-client label May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage     83.70%   83.70%           
  Complexity     2387     2387           
=========================================
  Files           250      250           
  Lines          6438     6438           
  Branches        586      586           
=========================================
  Hits           5389     5389           
  Misses          690      690           
  Partials        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ae5f6...b80039f. Read the comment docs.

@seratch seratch merged commit 98489af into slackapi:master May 12, 2020
@seratch seratch deleted the openjdk11-bug branch May 12, 2020 09:10
@seratch seratch mentioned this pull request May 21, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant