Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct users.conversations property type - created #754

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 3, 2021

This pull request applies the two changes:

  • Change the channels[].created type from string to integer
  • Update users.conversations response types with the latest data

Some conditional properties may be missing but we can improve it afterwards. We will include this change in the next minor version - v1.9. Java compiler detects if the change affects existing apps.

This is the upstream fix for slackapi/node-slack-sdk#1252

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model labels Jun 3, 2021
@seratch seratch added this to the 1.9.0 milestone Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #754 (ee346b8) into main (ffc3f59) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #754      +/-   ##
============================================
- Coverage     77.41%   77.38%   -0.04%     
+ Complexity     3303     3302       -1     
============================================
  Files           370      370              
  Lines          9807     9807              
  Branches        935      935              
============================================
- Hits           7592     7589       -3     
- Misses         1662     1664       +2     
- Partials        553      554       +1     
Impacted Files Coverage Δ
...va/com/slack/api/socket_mode/SocketModeClient.java 67.76% <0.00%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc3f59...ee346b8. Read the comment docs.

@seratch seratch merged commit afa3ce0 into slackapi:main Jun 3, 2021
@seratch seratch deleted the convo-created-type branch June 3, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant