Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Export helper methods such as verifyRequestSignature #70

Closed
4 of 9 tasks
ianwsperber opened this issue Aug 8, 2018 · 2 comments
Closed
4 of 9 tasks

Export helper methods such as verifyRequestSignature #70

ianwsperber opened this issue Aug 8, 2018 · 2 comments

Comments

@ianwsperber
Copy link
Contributor

ianwsperber commented Aug 8, 2018

Description

Hey all! First of all congrats on the 2.0.0 release! I'm excited to use this library to build a slack integration, but have found that I want more flexibility in my request handler than provided through the provided adapter abstraction and its express middleware. It would be nice if users had access to some of the helper methods used by the adapter. Specifically I'd like to be able to import the verifyRequestSignature method, so that I do not need to handroll that somewhat complicated bit of logic. I'm happy to create a PR for this change if you think it'd be of value. Unsure if there might be other methods worth exporting as well. Thanks!

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi
Copy link
Contributor

aoberoi commented Aug 8, 2018

found that I want more flexibility in my request handler than provided through the provided adapter abstraction and its express middleware

if you get a chance, i'd love to hear more about your usage and which abstractions you find helpful.

I'm happy to create a PR for this change if you think it'd be of value.

I think its a great idea, and I'd be happy to land this change!

@ianwsperber
Copy link
Contributor Author

Awesome, thanks @aoberoi! I'll create a PR shortly.

Re usage - our node application only has to listen for one or two events from slack and has functionality beyond the slack integration. I'm hesitant to implement the event emitter interface since it differs from our usual paradigms and so will be harder for the team to maintain and debug. So I'm opting to hand roll a controller that will do most the business logic, and just want to use the library to take care of the more onerous stuff. Since I have only just begun the integration I can't really speak to what is or isn't useful yet about the library and its abstractions, other than noting that this particular method will be very handy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants