Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added four new web-api methods #1049

Merged
merged 1 commit into from
Jul 7, 2020
Merged

added four new web-api methods #1049

merged 1 commit into from
Jul 7, 2020

Conversation

kian2attari
Copy link
Contributor

Summary

Added four methods to web-api:

  • admin.conversations.restrictAccess.addGroup
  • admin.conversations.restrictAccess.listGroups
  • admin.conversations.restrictAccess.removeGroup
  • conversations.mark

Linked issue: #1047

Requirements (place an x in each [ ])

@kian2attari kian2attari added semver:minor enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` labels Jul 7, 2020
@kian2attari kian2attari self-assigned this Jul 7, 2020
@stevengill stevengill requested a review from seratch July 7, 2020 19:22
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          12       12           
  Lines         778      778           
  Branches      176      176           
=======================================
  Hits          735      735           
  Misses         14       14           
  Partials       29       29           
Flag Coverage Δ
#eventsapi 89.67% <ø> (ø)
#interactivemessages 95.06% <ø> (ø)
#webapi 96.46% <ø> (ø)
#webhook 87.50% <ø> (ø)
Impacted Files Coverage Δ
src/methods.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dd9cb...07fe500. Read the comment docs.

@kian2attari kian2attari merged commit cc58887 into slackapi:master Jul 7, 2020
@kian2attari kian2attari deleted the issue-1047 branch July 7, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants