Changed type of created on UsersConversationsResponse #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Type was set to string, but it's actually a number
|
|
6 tasks
seratch
added
area:typescript
|
Hi @swaters-atlassian, thanks for pointing this out and taking the time to make this pull request! I'm happy to merge this PR (mainly to reflect your contribution!) but, after that, I will update the source file again. All the web-api response types rely on the normalized payload data generated by the Java SDK. The |
seratch
approved these changes
Jun 3, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the users.conversations response the type on the Channel object was set to string. This type is number on all other channel response types and I confirmed that we do get a number back from the API.
Requirements (place an
xin each[ ])