Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 12.x from CI build #1545

Merged
merged 2 commits into from Oct 18, 2022
Merged

Remove Node 12.x from CI build #1545

merged 2 commits into from Oct 18, 2022

Conversation

srajiang
Copy link
Member

Summary

Remove Node 12.x as it has been EOL'ed.

Requirements (place an x in each [ ])

@srajiang srajiang self-assigned this Oct 18, 2022
@@ -17,7 +17,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you update the document too? > https://slack.dev/node-slack-sdk/#requirements

This package supports Node v12 LTS and higher.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seratch - Yes, I see there are some docs that reference even older versions. I think I got them all!

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the changes 👍

@srajiang srajiang merged commit 8452c9e into main Oct 18, 2022
@srajiang srajiang deleted the sjiang-remove-node-12 branch October 18, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants