Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node 12.x from CI build #1545

Merged
merged 2 commits into from Oct 18, 2022
Merged

Remove Node 12.x from CI build #1545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf8260
Remove Node 12.x as it has been EOL'ed
srajiang Oct 18, 2022
4cb807f
Update requirements docs
srajiang Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yml
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you update the document too? > https://slack.dev/node-slack-sdk/#requirements

This package supports Node v12 LTS and higher.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seratch - Yes, I see there are some docs that reference even older versions. I think I got them all!


steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -100,7 +100,7 @@ Refer to [the module document page](https://slack.dev/node-slack-sdk/socket-mode

## Requirements

This package supports Node v12 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion docs/_main/index.md
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@ $ yarn add @slack/web-api @slack/events-api

## Requirements

This package supports Node v12 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion docs/_packages/oauth.md
View file
Open in desktop
Expand Up @@ -477,7 +477,7 @@ const installer = new InstallProvider({

### Requirements

This package supports Node v12 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion docs/_packages/socket_mode.md
View file
Open in desktop
Expand Up @@ -274,7 +274,7 @@ const socketModeClient = new SocketModeClient({

## Requirements

This package supports Node v12 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features from that version.

## Getting Help
Expand Down
2 changes: 1 addition & 1 deletion packages/events-api/README.md
View file
Open in desktop
Expand Up @@ -316,7 +316,7 @@ the `SlackEventAdapter`:

## Requirements

This package supports Node v8 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion packages/interactive-messages/README.md
View file
Open in desktop
Expand Up @@ -677,7 +677,7 @@ additional features of the `SlackMessageAdapter`:

## Requirements

This package supports Node v8 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion packages/oauth/README.md
View file
Open in desktop
Expand Up @@ -362,7 +362,7 @@ const installer = new InstallProvider({

### Requirements

This package supports Node v10 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion packages/rtm-api/README.md
View file
Open in desktop
Expand Up @@ -430,7 +430,7 @@ const rtm = new RTMClient(token, {

## Requirements

This package supports Node v8 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down
2 changes: 1 addition & 1 deletion packages/socket-mode/README.md
View file
Open in desktop
Expand Up @@ -222,7 +222,7 @@ const socketModeClient = new SocketModeClient({

## Requirements

This package supports Node v12 LTS and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features from that version.

## Getting Help
Expand Down
2 changes: 1 addition & 1 deletion packages/web-api/README.md
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ The `@slack/web-api` package contains a simple, convenient, and configurable HTT

## Requirements

This package supports Node v12.13 and higher. It's highly recommended to use [the latest LTS version of
This package supports Node v14 and higher. It's highly recommended to use [the latest LTS version of
node](https://github.com/nodejs/Release#release-schedule), and the documentation is written using syntax and features
from that version.

Expand Down