Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebClient constructor should allow no token #482

Closed
3 tasks done
aoberoi opened this issue Mar 10, 2018 · 3 comments · Fixed by #499
Closed
3 tasks done

WebClient constructor should allow no token #482

aoberoi opened this issue Mar 10, 2018 · 3 comments · Fixed by #499
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Mar 10, 2018

Description

In the cases of using the object to call methods like oauth.access, we shouldn't require a token.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Mar 10, 2018
@aoberoi aoberoi mentioned this issue Mar 10, 2018
Closed
3 tasks
clavin added a commit to clavin/node-slack-sdk that referenced this issue Mar 11, 2018
@clavin
allow unspecified arguments, fixes slackapi#482
24542ef
@aoberoi aoberoi mentioned this issue Mar 12, 2018
Closed
9 tasks
@aoberoi aoberoi added the area:typescript issues that specifically impact using the package from typescript projects label Mar 14, 2018
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Mar 14, 2018
@aoberoi
allow WebClient token to be undefined, fixes slackapi#482
99db715
@aoberoi aoberoi mentioned this issue Mar 14, 2018
Merged
2 tasks
@bilby91
Copy link

bilby91 commented Mar 14, 2018

Any ETA for a new release ?

@aoberoi
Copy link
Contributor Author

aoberoi commented Mar 14, 2018

today!

@bilby91
Copy link

bilby91 commented Mar 14, 2018

🎉

@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allows WebClient token to be undefined aoberoi/node-slack-sdk
2 participants
@aoberoi @bilby91