Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all argument types in methods.ts should be exported #483

Closed
3 tasks done
aoberoi opened this issue Mar 10, 2018 · 0 comments · Fixed by #502
Closed
3 tasks done

all argument types in methods.ts should be exported #483

aoberoi opened this issue Mar 10, 2018 · 0 comments · Fixed by #502
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Mar 10, 2018

Description

the symbol names aren't being exported, so some type information is being lost. for example, here is the type for a method: web.oauth.access: Method<methods.TokenOverridable>. i'd expect to see
web.oauth.access: Method<methods.OAuthAccessArguments>.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added enhancement M-T: A feature request for new functionality area:typescript issues that specifically impact using the package from typescript projects labels Mar 10, 2018
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects enhancement M-T: A feature request for new functionality
Projects
None yet
1 participant