Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in README and main documentation page #763

Merged
merged 3 commits into from
Apr 11, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Apr 2, 2019

Requirements (place an x in each [ ])

@aoberoi aoberoi requested a review from shaydewael April 10, 2019 22:07
@aoberoi
Copy link
Contributor Author

aoberoi commented Apr 10, 2019

something about the CI tests is flaky, and should be investigated. we got one failure from NPM for an integrity check (SHA sums were not matching), and another as a timeout. unfortunately, i already restarted the builds so I don't have the logs available. if it happens again, i'll create a separate issue for them.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          15       15           
  Lines         652      652           
  Branches       26       26           
=======================================
  Hits          638      638           
  Misses         13       13           
  Partials        1        1
Flag Coverage Δ
#eventsapi 95.62% <ø> (ø) ⬆️
#interactivemessages 99.18% <ø> (ø) ⬆️
#webapi 98.33% <ø> (ø) ⬆️
#webhook 90.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7247d38...3a32c51. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          15       15           
  Lines         652      652           
  Branches       26       26           
=======================================
  Hits          638      638           
  Misses         13       13           
  Partials        1        1
Flag Coverage Δ
#eventsapi 95.62% <ø> (ø) ⬆️
#interactivemessages 99.18% <ø> (ø) ⬆️
#webapi 98.33% <ø> (ø) ⬆️
#webhook 90.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7247d38...3a32c51. Read the comment docs.

@aoberoi aoberoi merged commit 961f9d8 into master Apr 11, 2019
@aoberoi aoberoi deleted the fix-broken-links branch April 11, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants