Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UserElement #905

Closed
3 tasks done
aoberoi opened this issue Nov 12, 2019 · 0 comments
Closed
3 tasks done

Remove UserElement #905

aoberoi opened this issue Nov 12, 2019 · 0 comments
Assignees
@stevengill
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented good first issue pkg:types applies to `@slack/types`

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Nov 12, 2019 •
edited

Description

The user element is not used in the public API. We should remove the UserElement type, and remove it from all unions its used within.

Example:

node-slack-sdk/packages/types/src/index.ts

Line 249 in 039e137

elements: (ImageElement | UserElement | PlainTextElement | MrkdwnElement)[];

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:types applies to `@slack/types` labels Nov 12, 2019
@aoberoi aoberoi changed the title Remove UserElement from possible elements in ContextBlock Remove UserElement Nov 12, 2019
@stevengill stevengill self-assigned this Nov 19, 2019
stevengill added a commit to stevengill/node-slack-sdk that referenced this issue Nov 19, 2019
@stevengill
Removed UserElement type in types package. In regards to slackapi#905
db199e4
@stevengill stevengill mentioned this issue Nov 19, 2019
Merged
2 tasks
stevengill added a commit that referenced this issue Nov 22, 2019
@stevengill
Merge pull request #912 from stevengill/Issue905
feb08d4 
Removed UserElement type in types package. In regards to #905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengill stevengill

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented good first issue pkg:types applies to `@slack/types`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevengill @aoberoi