Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the releasing operation to have the step to maintain GitHub milestones #1263

Merged
merged 2 commits into from Jun 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/maintainers_guide.md
Expand Up @@ -95,9 +95,11 @@ If you make a mistake, don't fret. NPM allows you to unpublish a release within
`npm publish . --otp YOUR_OTP_CODE` in each of the package directories.
* If you are releasing without learna, change into the package directory and run `npm publish . --otp YOUR_OTP_CODE`.

4. Create GitHub Release(s) and add release notes.
4. Close GitHub Milestone(s), create GitHub Release(s), and add release notes.
* Move any unfinished, open issues to the next GitHub Milestone
* Close the relevant GitHub Milestone(s) for the release(s)
seratch marked this conversation as resolved.
Show resolved Hide resolved
* Release notes should mention contributors (@-mentions) and issues/PRs (#-mentions).
* Example release: https://github.com/slackapi/node-slack-sdk/releases/tag/%40slack%2Fweb-api%405.11.0
* Example release: https://github.com/slackapi/node-slack-sdk/releases/tag/%40slack%2Fweb-api%406.2.0

5. (Slack Internal) Communicate the release internally. Include a link to the GitHub Release(s).

Expand Down