Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for Slack Connect APIs #1306

Merged
merged 7 commits into from Aug 12, 2021

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Aug 12, 2021

Summary

Adds integration tests for Slack Connect API endpoints

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 12, 2021
@srajiang srajiang self-assigned this Aug 12, 2021
@srajiang srajiang added tests M-T: Testing work only pkg:web-api applies to `@slack/web-api` semver:minor and removed untriaged labels Aug 12, 2021
@srajiang srajiang marked this pull request as ready for review August 12, 2021 22:56
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test!

@@ -29,7 +29,7 @@ describe('Web APIs', function () {
});
});

describe('cha.scheduleMessage', function () {
describe('chat.scheduleMessage', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@srajiang srajiang merged commit 7748ca3 into slackapi:main Aug 12, 2021
@srajiang srajiang deleted the sj-add-api-endpoints branch August 12, 2021 23:20
@seratch seratch added this to the web-api@6.4 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:web-api applies to `@slack/web-api` semver:minor tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants