Fix #1214 by adding more info in the ratelimited error exception message #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
srajiang
approved these changes
Aug 18, 2021
stevengill
approved these changes
Aug 18, 2021
seratch
commented
Aug 18, 2021
| } else { | ||
| // TODO: turn this into some CodedError | ||
| throw new AbortError(new Error('Retry header did not contain a valid timeout.')); | ||
| throw new AbortError(new Error(`Retry header did not contain a valid timeout (url: ${url})`)); |
There was a problem hiding this comment.
@srajiang @stevengill
Sorry for changes after the reviews but I just updated this one as well. It should be fine too.
stevengill
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #1214 by updating the Error thrown in the case where the WebClient receives a ratelimited error rom the server-side.
Requirements (place an
xin each[ ])