Update code to make it TS 4.4 compatible #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
area:typescript
seratch
changed the title
seratch
added
pkg:oauth
|
Okay, now all the errors are settled. We'd like to merge this as early as possible to smoothly accept contributions. |
26 tasks
seratch
commented
Aug 27, 2021
| @@ -39,7 +39,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@slack/logger": "^3.0.0", | |||
| "@slack/web-api": "^6.0.0", | |||
| "@slack/web-api": "^6.3.0", | |||
There was a problem hiding this comment.
This has not been safe enough. oauth.v2.access API argments in the code are compatible only with 6.3+
| @@ -191,7 +191,7 @@ export class InstallProvider { | |||
| } | |||
|
|
|||
| return authResult; | |||
| } catch (error) { | |||
| } catch (error: any) { | |||
There was a problem hiding this comment.
As either any or unknown is allowed for the type, we are unable to use more specific types here. If we want to do so, we have to cast the type from unknown inside the catch clause.
| this.logger.warn('http request failed', error.message); | ||
| if (error.request) { | ||
| throw requestErrorWithOriginal(error); | ||
| // To make this compatible with tsd, casting here instead of `catch (error: any)` |
There was a problem hiding this comment.
We run tsd type tests only for web-api package as of today
mwbrooks
approved these changes
Aug 27, 2021
|
Thanks for the review! Let me merge this not to block the following contributions! If we find better ways to change the code, we can update at any time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the compilation failures with the latest TypeScript compiler (v4.4.x)
Requirements (place an
xin each[ ])