Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1302 Invalid JSON string causing "Cannot create property 'response_metadata' on string" error #1321

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 27, 2021

Summary

This pull request fixes #1302. Refer to the issue for details.

Requirements (place an x in each [ ])

…rty 'response_metadata' on string" error
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api` labels Aug 27, 2021
@seratch seratch added this to the web-api@6.5.0 milestone Aug 27, 2021
@seratch seratch self-assigned this Aug 27, 2021
@seratch seratch changed the title Fix #1302 Invalid JSON string causin;5Dg "Cannot create property 'response_metadata' on string" error Fix #1302 Invalid JSON string causing "Cannot create property 'response_metadata' on string" error Aug 27, 2021
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

packages/web-api/src/WebClient.spec.js Outdated Show resolved Hide resolved
Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>
@seratch seratch merged commit cedad89 into slackapi:main Aug 29, 2021
@seratch seratch deleted the issue-1302-web-api-error branch August 29, 2021 07:23
srajiang pushed a commit that referenced this pull request Dec 10, 2021
…se_metadata' on string" error (#1321)

* Fix #1302 Invalid JSON string causin;5Dg "Cannot create property 'response_metadata' on string" error

* Fix

* Fix

* Apply suggestions from code review

Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>

Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JSON string causing "Cannot create property 'response_metadata' on string" error
2 participants