Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Add Subscribe in Slack API methods #1401

Merged

Conversation

srajiang
Copy link
Member

Summary

These changes were previously released as part of hermesBeta.1 to support beta release of Message Metadata features but changes were lost, so re-adding:

  • @slack/types - Metadata types object with Metadata fields
  • @slack/webapi - Adds metadata field to chat.postMessage and chat.update arguments

These new changes are added to support upcoming Subscribe in Slack feature:

  • @slack/types - Adds notification_subscription_id field to Metadata
  • @slack/webapi - Adds apps.notifications.subscriptions.* methods. Once java-slack-sdk Response types are updated, we can run the auto-gen script to update these as well.

Requirements (place an x in each [ ])

@srajiang srajiang added the enhancement M-T: A feature request for new functionality label Dec 10, 2021
@srajiang srajiang changed the title [betaFeatures] Add Subscribe in Slack API methods [beta] Add Subscribe in Slack API methods Dec 10, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, the changes look good to me.

(nice-to-have) If we have a test code or test script to verify the behavior here, it may be helpful for other maintainers.

@srajiang srajiang merged commit b70ec56 into slackapi:feat-hermes Dec 13, 2021
srajiang added a commit that referenced this pull request Feb 24, 2022
* Add Subscribe in Slack API methods and message metadata support
srajiang added a commit that referenced this pull request May 3, 2022
* Add Subscribe in Slack API methods and message metadata support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants