Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more exports to oauth/index.ts #1446

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 7, 2022

Summary

This pull request adds more exported items in the @slack/oauth package next version. Specifically the following items were missing the RC version:

  • InstallPathOptions interface (this is required for writing code in TypeScript)
  • defaultRenderHtmlForInstallPath function (totally optional but some bolt-js receivers may want to access this)
  • defaultCallbackSuccess, defaultCallbackFailure for CallbackOptions

Requirements (place an x in each [ ])

@seratch seratch self-assigned this Mar 7, 2022
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` labels Mar 7, 2022
@seratch seratch added this to the oauth@2.5.0 milestone Mar 7, 2022
packages/oauth/src/index.ts Outdated Show resolved Hide resolved
@seratch seratch merged commit f134cf2 into slackapi:main Mar 7, 2022
@seratch seratch deleted the oauth-package-exports branch March 7, 2022 22:12
@seratch seratch mentioned this pull request Mar 24, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants