Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@slack/web-api: prep for next major release. bump min node to v18 (#1667) #1684

Closed
wants to merge 7 commits into from
Closed

@slack/web-api: prep for next major release. bump min node to v18 (#1667) #1684

wants to merge 7 commits into from

Conversation

enza252
Copy link
Contributor

@enza252 enza252 commented Oct 30, 2023

Summary

Addresses hotfix recommendation in #1682 to resolve CVE-2023-45857 in web-client only.

Requirements (place an x in each [ ])

filmaj
filmaj requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @enza252 ! Can you drop almost the entirety of these changes and just keep the axios version bump? Things like bumping the minimum node version in the package.json could be interpreted as a breaking change.

@enza252
Copy link
Contributor Author

enza252 commented Oct 30, 2023

Sorry I think I've stuffed my fork's tracking of this. I'll re-open this

@enza252 enza252 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj requested changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enza252 @filmaj @chrisronline @adebay8 @marcomow