Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code property to RichTextStyleable #1707

Merged
merged 1 commit into from Dec 20, 2023
Merged

Add code property to RichTextStyleable #1707

merged 1 commit into from Dec 20, 2023

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Dec 20, 2023

Also removes unsupported highlight property (it did nothing, anyways).

Fixes #1706

@filmaj
Add code property to RichTextStyleable, remove unsupported `highl…
7827543 
…ight` property (it did nothing, anyways). Fixes #1706
@filmaj filmaj added semver:minor area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Dec 20, 2023
@filmaj filmaj self-assigned this Dec 20, 2023
@filmaj filmaj mentioned this pull request Dec 20, 2023
Closed
7 tasks
@filmaj filmaj requested a review from a team December 20, 2023 17:50
hello-ashleyintech
hello-ashleyintech approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@filmaj filmaj merged commit 0a44268 into main Dec 20, 2023
15 checks passed
@filmaj filmaj deleted the types-code-style branch December 20, 2023 18:06
@filmaj filmaj added this to the types@2.11 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-ashleyintech hello-ashleyintech hello-ashleyintech approved these changes

Assignees

@filmaj filmaj

Labels
area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` semver:minor
Projects
None yet
Milestone
types@2.11
Development

Successfully merging this pull request may close these issues.

Why is code property not included in RichTextStyleable type?
2 participants
@filmaj @hello-ashleyintech