Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for users.profile.*. Fixes #279 #297

Merged
merged 3 commits into from
Dec 12, 2016

Conversation

DEGoodmanWilson
Copy link

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Allows direct calls to users.profile.get and users.profile.set

Related Issues

Fixes #279

Test strategy

TBD

@codecov-io
Copy link

Current coverage is 85.65% (diff: 100%)

Merging #297 into master will increase coverage by 0.01%

@@             master       #297   diff @@
==========================================
  Files            44         44          
  Lines          1170       1171     +1   
  Methods         217        217          
  Messages          0          0          
  Branches        168        168          
==========================================
+ Hits           1002       1003     +1   
  Misses          168        168          
  Partials          0          0          

Powered by Codecov. Last update e9eb2bd...91b96b5

@DEGoodmanWilson DEGoodmanWilson merged commit aa28c99 into master Dec 12, 2016
@DEGoodmanWilson DEGoodmanWilson deleted the users.profile branch December 12, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants