Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unrecoverable errors #415

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

CharlieHess
Copy link
Contributor

Summary

This PR makes sure that user_removed_from_team and team_disabled are marked as unrecoverable errors during an rtm.start or rtm.connect. We were seeing cases in the desktop app wherein a user had been removed from the org but continued to retry the connection.

Requirements (place an x in each [ ])

@CharlieHess CharlieHess added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Oct 9, 2017
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          44       44           
  Lines        1241     1241           
  Branches      187      187           
=======================================
  Hits         1104     1104           
  Misses        137      137
Impacted Files Coverage Δ
lib/clients/rtm/client.js 84.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855f6ec...08f7c8e. Read the comment docs.

@Roach Roach merged commit eeb0400 into slackapi:master Oct 10, 2017
@CharlieHess CharlieHess deleted the more_unrecoverable_errors branch October 10, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants