Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuthAccessArguments should not be TokenOverridable #481

Closed
3 tasks done
aoberoi opened this issue Mar 10, 2018 · 0 comments · Fixed by #503
Closed
3 tasks done

OAuthAccessArguments should not be TokenOverridable #481

aoberoi opened this issue Mar 10, 2018 · 0 comments · Fixed by #503
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Mar 10, 2018

Description

this is just a flaw in the type definition. see https://api.slack.com/methods/oauth.access

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented area:typescript issues that specifically impact using the package from typescript projects labels Mar 10, 2018
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Mar 14, 2018
@aoberoi
more tightly specifies OAuthAccessArguments and OAuthTokenArguments, f…
7f8e5b7 
…ixes slackapi#481
@aoberoi aoberoi mentioned this issue Mar 14, 2018
Merged
2 tasks
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
1 participant
@aoberoi