more tightly specifies OAuthAccessArguments and OAuthTokenArguments #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoberoi
commented
Mar 14, 2018
src/methods.ts
Outdated
| client_secret: string; | ||
| code: string; | ||
| redirect_uri?: string; | ||
| single_channel?: boolean; |
There was a problem hiding this comment.
i'm not 100% sure if this is a boolean, or if it should be '0' | '1'. waiting for confirmation.
There was a problem hiding this comment.
it does not support boolean.
Currently it’s implemented to support specifically
1. Anything else will resolve to booleanfalsebehind the scenes.
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 6 6
Lines 241 241
Branches 37 37
=======================================
Hits 196 196
Misses 29 29
Partials 16 16
Continue to review full report at Codecov.
|
|
FYI: the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #481
Requirements (place an
xin each[ ])