Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency got with axios #620

Merged
merged 6 commits into from
Aug 23, 2018

Commits on Aug 22, 2018

  1. purge outdated comments

    aoberoi committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    050cbfa View commit details
    Browse the repository at this point in the history
  2. Replace dependency got with axios

    There's two main reasons for this implementation detail change:
    1) got has moved onto the next major version and drops support for node versions this
       package must continue to support. they have no plans to continue to ship features
       and bugfixes on the v8 release line.
    2) axios has a significantly reduced bundle size compared to got v8.x.
    
    This swap also removes the need for a couple ts-ignore pragmas. But, since axios' typings
    are much looser than got's, it also means the checks are less valuable. Still, it seems
    like the right tradeoff.
    aoberoi committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    40bb61c View commit details
    Browse the repository at this point in the history
  3. add method description

    aoberoi committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    861305c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8d9e24b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Configuration menu
    Copy the full SHA
    a917ec7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df2786d View commit details
    Browse the repository at this point in the history