Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global logging modification #671

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Dec 15, 2018

Summary

Removes the modification of the global loglevel methodFactory, as pointed out in #667

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #671 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   91.94%   91.92%   -0.02%     
==========================================
  Files           7        7              
  Lines         484      483       -1     
  Branches       90       90              
==========================================
- Hits          445      444       -1     
  Misses         22       22              
  Partials       17       17
Impacted Files Coverage Δ
src/logger.ts 89.47% <100%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4024612...aaec7c0. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Dec 17, 2018

thanks @clavin!

@aoberoi aoberoi merged commit 5688ab5 into slackapi:master Dec 17, 2018
@clavin clavin deleted the issue-667 branch July 9, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants