Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workspace apps code from getting started tutorial #676

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

benoitlavigne
Copy link
Contributor

Summary

Replacing workspace apps specific code in getting started's tutorial.js with user token code, related to #656
Minor edits to instructions

Requirements (place an x in each [ ])

Replacing workspace apps specific code in getting started's `tutorial.js` with user token code, related to slackapi#656
Minor edits to instructions
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files           7        7           
  Lines         483      483           
  Branches       90       90           
=======================================
  Hits          444      444           
  Misses         22       22           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbba95...5eaed8f. Read the comment docs.

docs/_pages/getting_started.md Outdated Show resolved Hide resolved
@aoberoi
Copy link
Contributor

aoberoi commented Jan 14, 2019

@benoitlavigne this looks great! thank you for contributing and improving the getting started experience 🥇

Co-Authored-By: benoitlavigne <bntlavigne@gmail.com>
@aoberoi aoberoi merged commit 6389b63 into slackapi:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants