Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.0 #756

Merged
merged 288 commits into from
Mar 28, 2019
Merged

Release v5.0.0 #756

merged 288 commits into from
Mar 28, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 28, 2019

Summary

Fixes #689

Requirements (place an x in each [ ])

Move header data to response_metadata in WebAPICallResult
Remove implementation() thunks
Remove workspace methods methods and types
…gration tests to verify

the last integration test is not passing in this commit, therefore this is still a WIP
aoberoi and others added 25 commits March 28, 2019 10:58
reference example apps in readmes, make async iteration example default
Co-Authored-By: shanedewael <swdewael@gmail.com>
Co-Authored-By: shanedewael <swdewael@gmail.com>
Co-Authored-By: shanedewael <swdewael@gmail.com>
its amazing what you can find with a little find and replace
@aoberoi
Copy link
Contributor Author

aoberoi commented Mar 28, 2019

Travis has been stalled for many hours. We're going to merge this now, and work on a release. If we find any problems, we may revert.

@aoberoi aoberoi merged commit a76b3ee into master Mar 28, 2019
"npm": ">= 5.5.1"
},
"repository": "slackapi/node-slack-sdk",
"homepage": "https://slack.dev/node-slack-sdk/tutorials/migrating_to_v5/",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ This URL leads to a 404

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #761

We’ll likely be releasing that today.

@aoberoi aoberoi deleted the dev-v5 branch April 2, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants