Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect homepage for legacy wrapper #793

Merged
merged 1 commit into from
May 30, 2019

Conversation

felixrieseberg
Copy link
Contributor

@felixrieseberg felixrieseberg commented May 28, 2019

Summary

👋 The link on https://www.npmjs.com/package/@slack/client is incorrect. We don't handle a final /, which in itself is probably worth looking at, but this ensures that npm doesn't route people to a disappointing 404 🙇

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented May 28, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          15       15           
  Lines         652      652           
  Branches       26       26           
=======================================
  Hits          638      638           
  Misses         13       13           
  Partials        1        1
Flag Coverage Δ
#eventsapi 95.62% <ø> (ø) ⬆️
#interactivemessages 99.18% <ø> (ø) ⬆️
#webapi 98.33% <ø> (ø) ⬆️
#webhook 90.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3b2fd...011d2dc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          15       15           
  Lines         652      652           
  Branches       26       26           
=======================================
  Hits          638      638           
  Misses         13       13           
  Partials        1        1
Flag Coverage Δ
#eventsapi 95.62% <ø> (ø) ⬆️
#interactivemessages 99.18% <ø> (ø) ⬆️
#webapi 98.33% <ø> (ø) ⬆️
#webhook 90.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3b2fd...011d2dc. Read the comment docs.

@aoberoi aoberoi merged commit 8266961 into slackapi:master May 30, 2019
@aoberoi
Copy link
Contributor

aoberoi commented May 30, 2019

thanks @felixrieseberg! we'll republish soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants