Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method name to apiCall debug #835

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Jul 22, 2019

Summary

Adds the name of the method being called by apiCall to the debug log message at the start of the method.

Requirements

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #835 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          15       15           
  Lines         652      652           
  Branches       26       26           
=======================================
  Hits          638      638           
  Misses         13       13           
  Partials        1        1
Flag Coverage Δ
#eventsapi 95.62% <ø> (ø) ⬆️
#interactivemessages 99.18% <ø> (ø) ⬆️
#webapi 98.33% <ø> (ø) ⬆️
#webhook 90.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e771e3c...0670958. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #835 into master will increase coverage by 2.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   95.72%   97.85%   +2.12%     
==========================================
  Files          12       15       +3     
  Lines         679      652      -27     
  Branches      145       26     -119     
==========================================
- Hits          650      638      -12     
- Misses         11       13       +2     
+ Partials       18        1      -17
Flag Coverage Δ
#eventsapi 95.62% <ø> (+6.01%) ⬆️
#interactivemessages 99.18% <ø> (+2.55%) ⬆️
#webapi 98.33% <ø> (-0.17%) ⬇️
#webhook 90.69% <ø> (+3.19%) ⬆️
Impacted Files Coverage Δ
src/WebClient.ts 97.64% <0%> (-0.81%) ⬇️
src/errors.ts 100% <0%> (ø) ⬆️
src/retry-policies.ts 100% <0%> (ø) ⬆️
src/http-handler.ts
src/index.ts
src/util.ts
src/adapter.ts
packages/interactive-messages/src/http-handler.js 98.38% <0%> (ø)
packages/interactive-messages/src/adapter.js 99.4% <0%> (ø)
packages/interactive-messages/src/util.js 100% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd26e23...267647c. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Jul 23, 2019

Not a huge deal (i've already approved) but if this is functionality we don't want to regress, then it would be nice to get a test to verify it.

@clavin
Copy link
Contributor Author

clavin commented Jul 23, 2019

I don't really know if the contents of a debug message is part of what we should be testing 🤔 Like, I don't know if this is really something developers should depend on so much as it is just useful information to figure out where something went wrong. Yay or nay?

@clavin clavin merged commit 673aaf3 into slackapi:master Jul 25, 2019
@clavin clavin deleted the api-call-extra-debug branch July 25, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants