Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for undocumented breaking change in TS3.6 #864

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Sep 13, 2019

Summary

This PR adds a cast to workaround a breaking change that occurred in TypeScript v3.6. We may later want to change the implementation to one that doesn't use a cast. At this moment it is critical to unblock all builds.

Fixes #863

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #864 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          12       12           
  Lines         686      686           
  Branches      147      147           
=======================================
  Hits          656      656           
  Misses         11       11           
  Partials       19       19
Flag Coverage Δ
#eventsapi 89.61% <ø> (ø) ⬆️
#interactivemessages 96.33% <ø> (ø) ⬆️
#webapi 98.5% <ø> (ø) ⬆️
#webhook 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828412a...c888408. Read the comment docs.

@aoberoi aoberoi merged commit 80c2cec into slackapi:master Sep 13, 2019
@aoberoi aoberoi deleted the issue-863 branch September 13, 2019 08:11
@aoberoi aoberoi added pkg:rtm-api applies to `@slack/rtm-api` semver:patch labels Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:rtm-api applies to `@slack/rtm-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken due to string enum member check failing
1 participant