Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone property to slack_sdk.models.TimePickerElement class #1249

Closed
1 of 9 tasks
seratch opened this issue Aug 1, 2022 · 1 comment
Closed
1 of 9 tasks

Add timezone property to slack_sdk.models.TimePickerElement class #1249

seratch opened this issue Aug 1, 2022 · 1 comment
Assignees
Labels
enhancement M-T: A feature request for new functionality good first issue Version: 3x web-client
Milestone

Comments

@seratch
Copy link
Member

seratch commented Aug 1, 2022

While Node and Java SDKs already have the new property, this Python SDK still does not have the newly added timezone property in the TimePickerElement.

We are still waiting for the document updates here but we can add the property with some general description (we can update it once the API documents are ready).

See also:

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x good first issue labels Aug 1, 2022
@seratch seratch added this to the 3.18.2 milestone Aug 1, 2022
@hello-ashleyintech hello-ashleyintech self-assigned this Aug 1, 2022
@seratch
Copy link
Member Author

seratch commented Aug 3, 2022

Fixed by #1251

@seratch seratch closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality good first issue Version: 3x web-client
Projects
None yet
Development

No branches or pull requests

2 participants