-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in timezone property for timepicker element #1251
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 111 111
Lines 11025 11026 +1
=======================================
+ Hits 9553 9554 +1
Misses 1472 1472
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fe8ce75
to
fedb48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM but can you revert the document changes? We generate them when releasing a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Summary
Adding in a new
timezone
string property to the TimePicker block element. See #1249 for more info.Along with adding in the new property in
slack_sdk/models/blocks/block_elements.py
, also updated and previewed the docs and added a unit test corresponding to the addition of this new property.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.