Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to start RTM client over a thread #605

Closed
4 of 9 tasks
aaguilartablada opened this issue Jan 27, 2020 · 3 comments
Closed
4 of 9 tasks

Impossible to start RTM client over a thread #605

aaguilartablada opened this issue Jan 27, 2020 · 3 comments
Labels
area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x
Milestone

Comments

@aaguilartablada
Copy link
Contributor

Description

When trying to start a RTM connection over a thread a RuntimeError appears:
RuntimeError: set_wakeup_fd only works in main thread

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

I will open a PullRequest with a solution

Reproducible in:

slackclient version: 2.5.0

python version: 3.6.8

OS version(s): RedHat 7.7

Steps to reproduce:

  1. Create a Thread that connect a RTM client
  2. Start the thread.
  3. Exception occurs.

Expected result:

RTM run in a thread different to main thread

Actual result:

RuntimeError: set_wakeup_fd only works in main thread

@aoberoi aoberoi added area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented labels Jan 29, 2020
@aoberoi
Copy link
Contributor

aoberoi commented Jan 29, 2020

Thanks for filing the issue. I was able to verify it, so I've added the bug label. As I noted in #606, we're currently revisiting the concurrency related issues in this project. I've added the area:concurrency label to bring this issue into that context.

@seratch
Copy link
Member

seratch commented Apr 21, 2020

@aaguilartablada Thank you very much for reporting this and making the PR #606. Let me close this issue now.

@seratch seratch closed this as completed Apr 21, 2020
@seratch seratch added this to the 2.6.0 milestone Apr 21, 2020
seratch added a commit to seratch/python-slack-sdk that referenced this issue Apr 21, 2020
@seratch
Copy link
Member

seratch commented May 15, 2020

👋 slackclient 2.6.0rc1 is out. The pre-release version contains fixes for your issue described here.
https://pypi.org/project/slackclient/2.6.0rc1/

One week later from now, we'll be releasing version 2.6.0 to PyPI.

If you have a chance, could you try the release candidate version out and let us know your feedback? Thank you very much for being patient with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x
Projects
None yet
Development

No branches or pull requests

3 participants