Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting superfluous_charset warnings since v2.4.0 #692

Closed
4 of 9 tasks
seratch opened this issue May 19, 2020 · 0 comments 路 Fixed by #693
Closed
4 of 9 tasks

Getting superfluous_charset warnings since v2.4.0 #692

seratch opened this issue May 19, 2020 · 0 comments 路 Fixed by #693
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Milestone

Comments

@seratch
Copy link
Member

seratch commented May 19, 2020

Description

It's late to notice this ... 馃うbut, since this commit 863e1d3 that was included in v2.4.0, this library has been sending application/x-www-form-urlencoded;charset=utf-8 for Content-Type request header. However, the ;charset=utf-8 is unnecessary and it has been causing the following warning in API responses.

{
  "warning": "superfluous_charset",
  "response_metadata": {
    "warnings": [
      "superfluous_charset"
    ]
  }
}

To know this more, reading the following blog post would be the best:

You鈥檝e sent Slack a message we totally understood, but we had to make some assumptions about the request to service it:
{ "ok": true, "warning": "superfluous_charset" }
In this example, the warning indicates that you鈥檝e sent us the right Content-type for the request, application/x-www-form-urlencoded, but you added an unneeded charset attribute.

https://medium.com/slack-developer-blog/well-wishes-and-warnings-in-the-web-api-489456837220

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

This issue is reproducable with any API method requests with request body in the application/x-www-form-urlencoded format.

Logs, screenshots, screencast, sample project, funny gif, etc.

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client v2.6 in-progress labels May 19, 2020
@seratch seratch added this to the 2.6.0 milestone May 19, 2020
seratch added a commit to seratch/python-slack-sdk that referenced this issue May 19, 2020
seratch added a commit that referenced this issue May 19, 2020
Fix #692 superfluous_charset warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant