Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 RTM Client will drop messages if they come in rapid succession #701

Closed
4 of 8 tasks
pbrackin opened this issue May 22, 2020 · 3 comments
Closed
4 of 8 tasks

2.6 RTM Client will drop messages if they come in rapid succession #701

pbrackin opened this issue May 22, 2020 · 3 comments
Labels
area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x
Milestone

Comments

@pbrackin
Copy link

Description

I am running both the WebClient and the RTMClient within a Django 2.2 framework. The WebClient has always worked great for us, but we need the RTM client in certain environments due to firewall issues. Django 2.2 is not really async friendly, so we need to run with run_async=False for now.

With the 2.5 client, I got it to work for the most part, but I would occasionally see the concurrent.futures._base.TimeoutError. Seeing the updates to 2.6, I decided to give it a go.

It works good as long as the messages don't arrive too fast. Anything on the order of like 2 msgs/sec though and the second message is a no-show.

For now I've reverted to the 2.5 client.

Not being totally sure what the expected functionality is, I opened this as a "question". But if y'all feel it's bug-worthy, feel free to set accordingly.

What type of issue is this? (place an x in one of the [ ])

  • [] bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

slackclient version: 2.6.0
python version: 3.6.9
OS version(s): MacOS, Ubuntu 16.04

Steps to reproduce:

  1. install new slack_client 2.6.0,
  2. Use RTM Client with run_async=False
  3. Not sure it matters, but I am running the client in a separate thread.
  4. send 2 messages in rapid succession

Expected result:

both messages arrive in fcn decorated by '@RTMClient.run_on(event="message")'

Actual result:

Only first message arrives.

Attachments:

@seratch seratch added this to the 2.6.x milestone May 22, 2020
@seratch seratch mentioned this issue May 24, 2020
9 tasks
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented area:concurrency Issues and PRs related to concurrency labels May 24, 2020
@seratch seratch modified the milestones: 2.6.x, 2.6.1 May 24, 2020
seratch added a commit that referenced this issue May 25, 2020
Fix #701 by reverting the change for simultaneous request handling
@seratch
Copy link
Member

seratch commented May 25, 2020

I will be releasing v2.6.1 very soon. The version no longer has this issue. Thanks for reporting this 🙇

@seratch
Copy link
Member

seratch commented May 25, 2020

v2.6.1 is out. Could you try it out when you have a chance?
https://pypi.org/project/slackclient/2.6.1/

Thanks again for taking the time to report this issue.

@pbrackin
Copy link
Author

That seems to have addressed this issue. Impressive turnaround time - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x
Projects
None yet
Development

No branches or pull requests

2 participants