Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1102 Add __contains__ method in slack_sdk.web.SlackResponse / AsyncSlackResponse #1104

Merged
merged 1 commit into from Aug 20, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 20, 2021

Summary

This pull request resolves #1102. Refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Aug 20, 2021
@seratch seratch added this to the 3.10.0 milestone Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1104 (38ddd37) into main (c23312c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   86.16%   86.18%   +0.02%     
==========================================
  Files         110      110              
  Lines        9951     9955       +4     
==========================================
+ Hits         8574     8580       +6     
+ Misses       1377     1375       -2     
Impacted Files Coverage Δ
slack_sdk/web/async_slack_response.py 90.47% <100.00%> (+3.59%) ⬆️
slack_sdk/web/slack_response.py 93.54% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23312c...38ddd37. Read the comment docs.

@@ -1,6 +1,6 @@
import unittest

from slack.web.async_slack_response import AsyncSlackResponse
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import had been just wrong

@seratch seratch merged commit d679144 into slackapi:main Aug 20, 2021
@seratch seratch deleted the issue-1102-contains branch August 20, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add __contains__ method in slack_sdk.web.SlackResponse / AsyncSlackResponse
1 participant