-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1218 - Reduce minimum number of overflow options #1219
Conversation
@@ -1524,7 +1524,7 @@ def __init__( | |||
Should be unique among all other action_ids in the containing block. | |||
Maximum length for this field is 255 characters. | |||
options (required): An array of option objects to display in the menu. | |||
Maximum number of options is 5, minimum is 2. | |||
Maximum number of options is 5, minimum is 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seratch I ran both of the documentation steps and it resulted in a ton of changes. Happy to include those here, but wanted to be sure before I pushed them all up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misscoded Thanks for checking that! More fixes would be appreciated 👍
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 111 111
Lines 10943 10943
=======================================
Hits 9475 9475
Misses 1468 1468
Continue to review full report at Codecov.
|
Thanks for fixing this issue! Let me merge this one as the first step now. |
Summary
Fixes #1218.
Though API documentation says a minimum of two options are required for the
overflow
menu, one is acceptable and works without issue. This PR updates the SDK's minimum number to match that.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.