Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the installation data queries to always return the latest bot token #1223

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 2, 2022

Summary

This pull request resolves the issue described at slackapi/bolt-python#664 for the built-in installation stores. Refer to the issue for the details.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x oauth labels Jun 2, 2022
@seratch seratch added this to the 3.17.1 milestone Jun 2, 2022
@seratch seratch self-assigned this Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1223 (b8f9b71) into main (c9dc6aa) will decrease coverage by 0.00%.
The diff coverage is 74.46%.

❗ Current head b8f9b71 differs from pull request most recent head 334ba14. Consider uploading reports for the commit 334ba14 to get more accurate results

@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         111      111              
  Lines       10943    10986      +43     
==========================================
+ Hits         9471     9508      +37     
- Misses       1472     1478       +6     
Impacted Files Coverage Δ
...sdk/oauth/installation_store/amazon_s3/__init__.py 79.28% <45.45%> (-2.48%) ⬇️
...lack_sdk/oauth/installation_store/file/__init__.py 83.56% <50.00%> (-3.11%) ⬇️
...dk/oauth/installation_store/sqlalchemy/__init__.py 98.23% <100.00%> (+0.23%) ⬆️
...k_sdk/oauth/installation_store/sqlite3/__init__.py 84.44% <100.00%> (+1.11%) ⬆️
slack_sdk/socket_mode/websocket_client/__init__.py 85.61% <0.00%> (+1.43%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.36% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9dc6aa...334ba14. Read the comment docs.

@srajiang srajiang self-requested a review June 2, 2022 16:11
@seratch seratch force-pushed the latest-bot-token-installation branch from b8f9b71 to 334ba14 Compare June 2, 2022 17:28
@seratch seratch merged commit d53660f into slackapi:main Jun 13, 2022
@seratch seratch deleted the latest-bot-token-installation branch June 13, 2022 21:21
morningcloud added a commit to morningcloud/slack_installation_store that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented oauth Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant