Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update: max elements in ActionsBlock to 25 #1253

Closed
wants to merge 2 commits into from
Closed

Minor update: max elements in ActionsBlock to 25 #1253

wants to merge 2 commits into from

Conversation

YSaxon
Copy link
Contributor

@YSaxon YSaxon commented Aug 5, 2022

It seems from practical testing with the slack block kit builder that the (new?) max number of elements allowed in an ActionsBlock is 25, rather than 5 as previously enforced in the code.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

It seems from practical testing with the slack block kit builder that the (new?) max number of elements allowed in an ActionsBlock is 25, rather than 5 as previously shown in the code.
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2022

CLA assistant check
All committers have signed the CLA.

@YSaxon YSaxon marked this pull request as ready for review August 5, 2022 20:39
@YSaxon
Copy link
Contributor Author

YSaxon commented Aug 5, 2022

Screen Shot 2022-08-05 at 4 41 46 PM
(slack block kit builder showing max elements in an actionblock = 25)

@seratch seratch added this to the 3.18.2 milestone Aug 5, 2022
@seratch seratch self-assigned this Aug 5, 2022
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Aug 5, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me

@seratch
Copy link
Member

seratch commented Aug 15, 2022

Merged by 623ace0 - I've added a commit to apply corresponding changes to the existing unit tests. Thanks again fro your contribution!

@seratch seratch closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants