Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug on the aiohttp-based Socket Mode client's exception handling #1440

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

ifmcnichols
Copy link
Contributor

@ifmcnichols ifmcnichols commented Dec 1, 2023

Summary

__init__.py redeclared type before using it, leading to an error when the exception in receive_messages was reached.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

salesforce-cla bot commented Dec 1, 2023

Thanks for the contribution! Before we can merge this, we need @ifmcnichols to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added this to the 3.26.1 milestone Dec 1, 2023
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode area:async labels Dec 1, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19134d1) 85.44% compared to head (004aed0) 85.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
+ Coverage   85.44%   85.48%   +0.04%     
==========================================
  Files         111      111              
  Lines       12113    12113              
==========================================
+ Hits        10350    10355       +5     
+ Misses       1763     1758       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 09fb1db into slackapi:main Dec 2, 2023
12 checks passed
@seratch seratch changed the title Stop from re-declaring 'type' keyword Fix a bug on the aiohttp-based Socket Mode client's exception handling Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants