Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin moto, and support moto 5.0 changes #1463

Merged
merged 1 commit into from Feb 21, 2024

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

To stop testing with old versions of moto, unpin it from version 3, to the latest, and also change the test cases to cope with the new changes.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

Thanks for the contribution! Before we can merge this, we need @s-t-e-v-e-n-k to sign the Salesforce Inc. Contributor License Agreement.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60b02d6) 85.33% compared to head (b0e4026) 85.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
+ Coverage   85.33%   85.41%   +0.08%     
==========================================
  Files         111      111              
  Lines       12289    12289              
==========================================
+ Hits        10487    10497      +10     
+ Misses       1802     1792      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @s-t-e-v-e-n-k thank you for the contribution 💯 unfortunately these change would require that we drop support for python 3.6 and 3.7 which would require a major version bump and a deprecation notice
As of our latest data analysis it seem like there are still 10-15% of our developers that use python 3.6 and 3.7, since this tool is used internally by customers we try to be as generous as possible with regard to version support

If you can make these changes compatible with python 3.6 and 3.7 I will be able to approve them

@s-t-e-v-e-n-k
Copy link
Contributor Author

@WilliamBergamin Thanks for the quick review! I've adapted my changes to support 3.6 and 3.7.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you 💯 requesting one change more change but then we should be good to ship

requirements/testing.txt Outdated Show resolved Hide resolved
@WilliamBergamin WilliamBergamin added the tests M-T: Testing work only label Feb 20, 2024
To stop testing with old versions of moto, unpin it from version 3, to
the latest, depending on the Python version being used. Support both
version 4 and 5 in the test suite.
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@WilliamBergamin WilliamBergamin merged commit fe45e0b into slackapi:main Feb 21, 2024
12 checks passed
@seratch seratch added this to the 3.27.1 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants